Эх сурвалжийг харах

review:【INFRA 基础设施】代码生成的 review

YunaiV 5 сар өмнө
parent
commit
73e4f831f2

+ 1 - 1
yudao-framework/yudao-spring-boot-starter-mybatis/src/main/java/cn/iocoder/yudao/framework/mybatis/core/dataobject/BaseDO.java

@@ -54,7 +54,7 @@ public abstract class BaseDO implements Serializable, TransPojo {
     private Boolean deleted;
     private Boolean deleted;
 
 
     /**
     /**
-     * 把 creator、createTime、updateTime、updater 都清空,避免前端直接传递 creator 之类的字段,直接就被更新了
+     * 把 creator、createTime、updateTime、updater 都清空,避免前端直接传递 creator 之类的字段,直接就被更新了
      */
      */
     public void clean(){
     public void clean(){
         this.creator = null;
         this.creator = null;

+ 1 - 0
yudao-module-infra/src/main/java/cn/iocoder/yudao/module/infra/controller/admin/demo/demo03/erp/Demo03StudentErpController.java

@@ -67,6 +67,7 @@ public class Demo03StudentErpController {
     @Operation(summary = "批量删除学生")
     @Operation(summary = "批量删除学生")
     @PreAuthorize("@ss.hasPermission('infra:demo03-student:delete')")
     @PreAuthorize("@ss.hasPermission('infra:demo03-student:delete')")
     public CommonResult<Boolean> deleteDemo03StudentList(@RequestParam("ids") List<Long> ids) {
     public CommonResult<Boolean> deleteDemo03StudentList(@RequestParam("ids") List<Long> ids) {
+        // TODO @puhui999:deleteDemo03StudentList
         demo03StudentErpService.deleteDemo03StudentListByIds(ids);
         demo03StudentErpService.deleteDemo03StudentListByIds(ids);
         return success(true);
         return success(true);
     }
     }

+ 1 - 0
yudao-module-infra/src/main/resources/codegen/java/service/serviceImpl.vm

@@ -65,6 +65,7 @@ public class ${table.className}ServiceImpl implements ${table.className}Service
 #end
 #end
         // 插入
         // 插入
 #if ($voType == 10)
 #if ($voType == 10)
+## TODO @puhui999:insert 也要加下 clean。万一前端乱传递,哈哈哈。这个就是 do 模式的缺点;(只在 do 模式下);看看主子表,是不是也可能存在,insert 的时候;
         ${table.className}DO ${classNameVar} = BeanUtils.toBean(createReqVO, ${table.className}DO.class);
         ${table.className}DO ${classNameVar} = BeanUtils.toBean(createReqVO, ${table.className}DO.class);
 #end
 #end
         ${classNameVar}Mapper.insert(${classNameVar});
         ${classNameVar}Mapper.insert(${classNameVar});

+ 1 - 0
yudao-module-infra/src/main/resources/codegen/vue3_vben5_antd/general/api/api.ts.vm

@@ -102,6 +102,7 @@ export function export${simpleClassName}(params: any) {
 }
 }
 
 
 ## 特殊:主子表专属逻辑
 ## 特殊:主子表专属逻辑
+## TODO @puhui999:下面这块缩进调整了,会乱掉么?
 #foreach ($subTable in $subTables)
 #foreach ($subTable in $subTables)
   #set ($index = $foreach.count - 1)
   #set ($index = $foreach.count - 1)
   #set ($subSimpleClassName = $subSimpleClassNames.get($index))
   #set ($subSimpleClassName = $subSimpleClassNames.get($index))